Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linux-native feature condition #193

Closed
wants to merge 1 commit into from
Closed

Fix linux-native feature condition #193

wants to merge 1 commit into from

Conversation

Brooooooklyn
Copy link

No description provided.

brotskydotcom
brotskydotcom approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@brotskydotcom brotskydotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, thanks. Can you please file a bug about this and explain exactly what happened that made you notice the problem? (For example: "I turned on the linux-native feature but ended up with the mock credential store as the default.")

@brotskydotcom
Copy link
Collaborator

Thanks for noticing this issue, Brooklyn! It turns out there are some other code issues that your fix reveals, so I'm going to close this PR, file the bug, and the make a new release that incorporates your changes (crediting you, of course). Hopefully the new release will be out before you even get a chance to read this comment :).

@brotskydotcom brotskydotcom mentioned this pull request Jul 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brotskydotcom brotskydotcom brotskydotcom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brooooooklyn @brotskydotcom